Further cleanup GC code for map/list/set #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
approved these changes
Jun 5, 2024
runtime/alloc/alloc.cpp
Outdated
| @@ -151,4 +151,61 @@ __attribute__((always_inline)) void *kore_alloc_floating_old(size_t requested) { | |||
| init_with_len(result, sizeof(floating_hdr) - sizeof(blockheader)); | |||
| return &result->f; | |||
| } | |||
|
|
|||
| void *kore_alloc_map(size_t requested) { | |||
There was a problem hiding this comment.
Could these be sensibly factored out into a common function? As it is we have three identical bits of code, except for the tag that they are parametrised on. I might be missing something that will change in the next set of PRs, though
There was a problem hiding this comment.
I believe it should be possible with an inline template function. I'll take a stab at it.
Baltoli
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further cleanup of the code used to deal with map/list/set objects that are returned by functions and not immediately placed into a term. Previously, these objects lived on the alwaysgcspace and were promoted to the youngspace by placing them as a child of a special placeholder symbol if they survived to a collection cycle. However, this had the undesirable trait that it breaks the invariant originally imagined by the alwaysgcspace that it should not contain any allocations that might survive past the beginning of the next rewrite step.
Because of this, we were unable to separate the alwaysgcspace clear operation from the garbage collection cycle, something that is required for the sequence of GC refactorings I am in the progress of. To fix this, we simply change the way we allocate such map/list/set terms such that we allocate them directly to the youngspace as special placeholder symbols, rather than going through the intermediary of the alwaysgcspace. This resets the expectations that ultimately lead to the alwaysgcspace having the property that allocations might survive past the end of the current rewrite step, which allows us to make a further cleanup in the next PR which automatically resets and clears the space after every rewrite step.